Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented ILogger interface (#6) #7

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Implemented ILogger interface (#6) #7

merged 4 commits into from
Jul 30, 2024

Conversation

dhindrik
Copy link
Owner

No description provided.

@dhindrik dhindrik mentioned this pull request Jul 21, 2024
@dhindrik dhindrik added enhancement New feature or request library labels Jul 21, 2024
@dhindrik dhindrik self-assigned this Jul 21, 2024
TinyInsights.TestApp/MainPage.xaml.cs Show resolved Hide resolved
TinyInsights/InsightsExtension.cs Show resolved Hide resolved

var logTask = logLevel switch {
LogLevel.Trace => TrackPageViewAsync(GetEventName(eventId), GetLoggerData(logLevel, eventId, state, exception, formatter)),
LogLevel.Debug => Task.CompletedTask,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the Debug option correct ?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any suggestion how I should log Debug data?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now use Debug.WriteLine to output data there. What do you think about that?

@dhindrik dhindrik linked an issue Jul 25, 2024 that may be closed by this pull request
@dhindrik dhindrik merged commit bcfe9ba into main Jul 30, 2024
1 check passed
@dhindrik dhindrik deleted the ILogger branch September 10, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ilogger
2 participants