Support lights "nospecular" parm (if explicitly enabled) #643
+57
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs testing, which implies a custom testmap (that someone - not me - has to create). |
based on dhewm#254 The "nospecular" parm will only be used if either r_supportNoSpecular is set to 1 or r_supportNoSpecular is set to -1 (the default) and the maps spawnargs contain "allow_nospecular" "1" This probably doesn't work with (time)demos yet, because I think when they're being played I can't access the worldspawn entity
DanielGibson
force-pushed
the
fix-no-specular
branch
from
cbc99fc to
8812041
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #254
The "nospecular" parm will only be used if either
r_supportNoSpecular is set to 1
or r_supportNoSpecular is set to -1 (the default) and the maps spawnargs contain "allow_nospecular" "1"
Drawback: I think the current code doesn't work with (time)demos, as I think that I can't access the maps spawnargs when playing one