Skip to content

Commit

Permalink
Fix not passing module into docker build args (game-ci#147)
Browse files Browse the repository at this point in the history
  • Loading branch information
AndrewKahr authored Jan 24, 2022
1 parent 48e6d73 commit d8e91b6
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ jobs:
--build-arg baseImage=unityci/base:windows-${{ steps.buildParameters.outputs.repoVersionFull }} `
--build-arg version=${{ steps.buildParameters.outputs.editorVersion }} `
--build-arg changeSet=${{ steps.buildParameters.outputs.changeSet }} `
--build-arg module=${{ matrix.targetPlatform }} `
--tag unityci/editor:windows-${{ steps.buildParameters.outputs.editorVersion }}-${{ matrix.targetPlatform }}-${{ steps.buildParameters.outputs.repoVersionMinor }} `
--tag unityci/editor:windows-${{ steps.buildParameters.outputs.editorVersion }}-${{ matrix.targetPlatform }}-${{ steps.buildParameters.outputs.repoVersionMajor }} `
--tag unityci/editor:windows-${{ steps.buildParameters.outputs.editorVersion }}-${{ matrix.targetPlatform }}-${{ steps.buildParameters.outputs.repoVersionFull }}
Expand All @@ -176,6 +177,7 @@ jobs:
--build-arg baseImage=unityci/base:windows-${{ steps.buildParameters.outputs.repoVersionFull }} `
--build-arg version=${{ steps.buildParameters.outputs.editorVersion }} `
--build-arg changeSet=${{ steps.buildParameters.outputs.changeSet }} `
--build-arg module=${{ matrix.targetPlatform }} `
--tag unityci/editor:windows-${{ steps.buildParameters.outputs.editorVersion }}-${{ matrix.targetPlatform }}-${{ steps.buildParameters.outputs.repoVersionMinor }} `
--tag unityci/editor:windows-${{ steps.buildParameters.outputs.editorVersion }}-${{ matrix.targetPlatform }}-${{ steps.buildParameters.outputs.repoVersionMajor }} `
--tag unityci/editor:windows-${{ steps.buildParameters.outputs.editorVersion }}-${{ matrix.targetPlatform }}-${{ steps.buildParameters.outputs.repoVersionFull }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ jobs:
--build-arg baseImage=unityci/base:windows-${{ steps.buildParameters.outputs.repoVersionFull }} `
--build-arg version=${{ steps.buildParameters.outputs.editorVersion }} `
--build-arg changeSet=${{ steps.buildParameters.outputs.changeSet }} `
--build-arg module=${{ matrix.targetPlatform }} `
--tag unityci/editor:windows-${{ steps.buildParameters.outputs.editorVersion }}-${{ matrix.targetPlatform }}-${{ steps.buildParameters.outputs.repoVersionMinor }} `
--tag unityci/editor:windows-${{ steps.buildParameters.outputs.editorVersion }}-${{ matrix.targetPlatform }}-${{ steps.buildParameters.outputs.repoVersionMajor }} `
--tag unityci/editor:windows-${{ steps.buildParameters.outputs.editorVersion }}-${{ matrix.targetPlatform }}-${{ steps.buildParameters.outputs.repoVersionFull }}
Expand All @@ -176,6 +177,7 @@ jobs:
--build-arg baseImage=unityci/base:windows-${{ steps.buildParameters.outputs.repoVersionFull }} `
--build-arg version=${{ steps.buildParameters.outputs.editorVersion }} `
--build-arg changeSet=${{ steps.buildParameters.outputs.changeSet }} `
--build-arg module=${{ matrix.targetPlatform }} `
--tag unityci/editor:windows-${{ steps.buildParameters.outputs.editorVersion }}-${{ matrix.targetPlatform }}-${{ steps.buildParameters.outputs.repoVersionMinor }} `
--tag unityci/editor:windows-${{ steps.buildParameters.outputs.editorVersion }}-${{ matrix.targetPlatform }}-${{ steps.buildParameters.outputs.repoVersionMajor }} `
--tag unityci/editor:windows-${{ steps.buildParameters.outputs.editorVersion }}-${{ matrix.targetPlatform }}-${{ steps.buildParameters.outputs.repoVersionFull }}
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/retry-windows-editor-image-requested.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ jobs:
--build-arg baseImage=unityci/base:windows-${{ github.event.client_payload.repoVersionFull }} `
--build-arg version=${{ github.event.client_payload.editorVersion }} `
--build-arg changeSet=${{ github.event.client_payload.changeSet }} `
--build-arg module=${{ github.event.client_payload.targetPlatform }} `
--tag unityci/editor:windows-${{ github.event.client_payload.editorVersion }}-${{ github.event.client_payload.targetPlatform }}-${{ github.event.client_payload.repoVersionMinor }} `
--tag unityci/editor:windows-${{ github.event.client_payload.editorVersion }}-${{ github.event.client_payload.targetPlatform }}-${{ github.event.client_payload.repoVersionMajor }} `
--tag unityci/editor:windows-${{ github.event.client_payload.editorVersion }}-${{ github.event.client_payload.targetPlatform }}-${{ github.event.client_payload.repoVersionFull }}
Expand All @@ -118,6 +119,7 @@ jobs:
--build-arg baseImage=unityci/base:windows-${{ github.event.client_payload.repoVersionFull }} `
--build-arg version=${{ github.event.client_payload.editorVersion }} `
--build-arg changeSet=${{ github.event.client_payload.changeSet }} `
--build-arg module=${{ github.event.client_payload.targetPlatform }} `
--tag unityci/editor:windows-${{ github.event.client_payload.editorVersion }}-${{ github.event.client_payload.targetPlatform }}-${{ github.event.client_payload.repoVersionMinor }} `
--tag unityci/editor:windows-${{ github.event.client_payload.editorVersion }}-${{ github.event.client_payload.targetPlatform }}-${{ github.event.client_payload.repoVersionMajor }} `
--tag unityci/editor:windows-${{ github.event.client_payload.editorVersion }}-${{ github.event.client_payload.targetPlatform }}-${{ github.event.client_payload.repoVersionFull }}
Expand Down

0 comments on commit d8e91b6

Please sign in to comment.