Adds LocaleProvider for Custom Localization #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new LocaleProvider can be bound to a custom implementation that does not necessarily use the browser locale. This is useful if the Locale should be mapped to a specific value for a custom domain name for example.
The new LocaleProvider can be bound to a custom implementation that does not necessarily use the browser locale. This is useful if the Locale should be mapped to a specific value for a custom domain name for example.
… localeProvider Conflicts: sitebricks/src/main/java/com/google/sitebricks/SitebricksModule.java sitebricks/src/main/java/com/google/sitebricks/locale/LocaleProvider.java sitebricks/src/main/java/com/google/sitebricks/locale/LocaleProviderImpl.java
Exchanged the HttpServletRequest with the new LocaleProvider.
|
Dhanji R. Prasanna » sitebricks #197 SUCCESS |
In case of a missing localization for the full Locale (language and country) a fallback Locale consisting of the language only was used. This change fixes the behavior so that it works as expected.
|
Dhanji R. Prasanna » sitebricks #206 FAILURE |
|
Dhanji R. Prasanna » sitebricks #207 FAILURE |
In case of a missing localization for the full Locale (language and country) a fallback Locale consisting of the language only was used. This change fixes the behavior so that it works as expected.
Conflicts: sitebricks/src/test/java/com/google/sitebricks/LocalizationTest.java
|
Dhanji R. Prasanna » sitebricks #208 FAILURE |
|
Dhanji R. Prasanna » sitebricks #209 FAILURE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the ability to bind a custom LocaleProvider that is used to localize the pages according to custom requirements, not only based on the Http request data.