-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go back to using --omitNull
instead of --omitEmpty
#110
Conversation
Fixes #86 The motivation of this is to more accurately model the Kubernetes API semantics by not auto-omitting empty fields. This is because a field set to `Some ([] : List T)` is not necessarily the same as `None (List T)`. This makes the typical case a bit more verbose (more `Some`s), but the difference to the `./examples` shows that it's not too bad.
Lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this!
The script that builds the example in dhall-kubernetes still uses @Gabriel439 Is it still correct or is it something that should be changed ? |
@Gabriel439 Thx Looks like the nix script also uses the As an aside question, what's the best option for dhall-kubernetes between dhall-yaml and |
@PierreR: I think both should be fine if all you use is the command-line tool. The main advantage of the I also have another pull request up to also remove the |
Fixes #86
The motivation of this is to more accurately model the Kubernetes
API semantics by not auto-omitting empty fields. This is because
a field set to
Some ([] : List T)
is not necessarily the sameas
None (List T)
.This makes the typical case a bit more verbose (more
Some
s), butthe difference to the
./examples
shows that it's not too bad.