dhall-docs: Fix white flashes on page load in dark mode #2574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kukimik
force-pushed
the
dark_flash
branch
2 times, most recently
from
c1fe557 to
c701c6d
Compare
|
The hydra build failed with: which is probably not my fault. |
We set the class indicating that dark mode is enabled before the page is rendered (the script is called inside `<head>`). The class is now set on the `<html>` element instead of `<body>` because `document.body` is not ready yet when the script is executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading a page with dark mode enabled currently results in a short white flash. This happens because the page is first rendered in light mode, and only after it is loaded the class indicating that dark mode is enabled is toggled. The effect is even more visible because of the 0.5s transition effect set in CSS.
This PR solves the problem by toggling the class indicating that dark mode is enabled before the page is rendered (the script is called inside
<head>). The class is now set on the<html>element instead of<body>becausedocument.bodyis not ready yet when the script is executed.