dhall-openapi: Fix autoscaler preference #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to dhall-lang/dhall-kubernetes#191 Before this change the `v1`, `v2beta{1,2}` versions were preferred over *all* other versions (even newer versions like `v2`). This change fixes the comparison logic so that the hardcoded exception doesn't affect any other comparisons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dhall-lang/dhall-kubernetes#191
Before this change the
v1,v2beta{1,2}versions were preferred over all other versions (even newer versions likev2). This change fixes the comparison logic so that the hardcoded exception doesn't affect any other comparisons.