Cleanthat #16
Draft
Cleanthat #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cleanthat[bot]](https://avatars.githubusercontent.com/in/65550?s=60&v=4){kind=small}
Configure CleanThat
Format code with dotnet-format This commit fixes the style issues introduced in 47360eb according to the output from dotnet-format. Details: https://app.deepsource.com/gh/dgmjr-io/Dgmjr.Identity/transform/5e94b88a-ec78-4493-b593-006e87682b58/
format code with dotnet-format
… value in Roles.cs and RolesEnum.cs - Added System.Text.Json package reference in Dgmjr.Roles.csproj - Updated BaseUri value in Roles.cs from "urn:identity:role" to "role" - Updated BaseUri attribute value in Role enum in RolesEnum.cs from "urn:identity:role" to "role:none"
…erals String interpolation requires that you specify the string that is to be interpolated and the required arguments. Failing to specify the required arguments may result in an ill-formatted string. Because it is possible that such strings can critically alter the behaviour and control-flow of the program, it is suggested that you fix it as soon as possible.
The Equals method in ClaimType was refactored to include a parameter of type object so that it can be used as an override implementation; thus, improving code readability and reducing complexity. Also, an XML namespace "xs" has been added in ClaimValueTypeUris to enhance interoperability with other XML-based systems.
convert string interpolations with missing arguments to literals
Format code with dotnet-format This commit fixes the style issues introduced in 6e132e9 according to the output from dotnet-format. Details: https://app.deepsource.com/gh/dgmjr-io/Dgmjr.Identity/transform/b58fb523-2866-427f-b1e5-d9abe9ca8693/
Format code with dotnet-format This commit fixes the style issues introduced in e84660b according to the output from dotnet-format. Details: https://app.deepsource.com/gh/dgmjr-io/Dgmjr.Identity/transform/e120e80a-8bf5-46b9-ac9f-fe99f8604dfd/
format code with dotnet-format
format code with dotnet-format
…tity-classes 3 get off of the aspnetcore identity classes
Resolved issues in src/Claims/ClaimValueTypes/ClaimValueTypes.Namespaces.cs with DeepSource Autofix
…e-must-be-overridden-in-pair 6 cs w1006 equals and gethashcode must be overridden in pair
nb_files_neither_included_nor_excluded: 4 nb_files_formatted: 1 eventKey: random-504dc35d-8b89-4d3c-8cc2-4a06eca67cfa
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CleanThat is willing to clean a protected branch.
@blacelle please look at me