Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify explanation for exposed ports for httpGet in probes #312

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions e.observability.md
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,11 @@ spec:
imagePullPolicy: IfNotPresent
name: nginx
resources: {}
ports:
- containerPort: 80 # Note: Readiness probes runs on the container during its whole lifecycle. Since nginx exposes 80, containerPort: 80 is not required for readiness to work.
# Note: Readiness probes runs on the container during its whole lifecycle. Since nginx will serve on port 80 and the readiness probe tests that port from within the container, it is not required to expose containerPort 80.
readinessProbe: # declare the readiness probe
httpGet: # add this line
path: / #
port: 80 #
port: 80 # test usage of containerport 80
dnsPolicy: ClusterFirst
restartPolicy: Never
status: {}
Expand Down