Add missing attributes #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dgieselaar |
dgieselaar
merged commit 4c60d88
into
dgieselaar:strict-keys-array-check
1 of 2 checks passed
dgieselaar
pushed a commit
that referenced
this pull request
Oct 22, 2024
…t accessibility should use expected a11y attributes (elastic#196844) ## Summary We're working on upgrading Kibana to React@18 (in Legacy Mode). There are a couple failing tests when running React@18 in Legacy mode and this is one of them [[job]](https://buildkite.com/elastic/kibana-pull-request/builds/243743#01929ee7-11b8-41c3-af79-1437561a6ef0) [[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/243743/jobs/01929ee7-11b8-41c3-af79-1437561a6ef0/artifacts/01929f0a-dc7a-42ff-9a01-809c31e1dc71) FTR Configs #58 / discover/group3 discover doc viewer flyout accessibility should use expected a11y attributes This one is simple. Native to react `useId` implementation produces ids like this: `:r3:` and when you attempt to use such ids with id selector they're invalid . e.g. `document.querySelector('#:r3:')` throws an error. A workaround is to use attribute selector `document.querySelector('[id=":r3:"]')`. This is the same problem as we've seen before elastic#191632
dgieselaar
pushed a commit
that referenced
this pull request
Nov 20, 2024
… flyout accessibility should use expected a11y attributes (elastic#196844) (elastic#196872) # Backport This will backport the following commits from `main` to `8.x`: - [[React@18 failing test] fix discover/group3 discover doc viewer flyout accessibility should use expected a11y attributes (elastic#196844)](elastic#196844) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T12:59:44Z","message":"[React@18 failing test] fix discover/group3 discover doc viewer flyout accessibility should use expected a11y attributes (elastic#196844)\n\n## Summary\r\n\r\nWe're working on upgrading Kibana to React@18 (in Legacy Mode). There\r\nare a couple failing tests when running React@18 in Legacy mode and this\r\nis one of them\r\n\r\n\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/243743#01929ee7-11b8-41c3-af79-1437561a6ef0)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/243743/jobs/01929ee7-11b8-41c3-af79-1437561a6ef0/artifacts/01929f0a-dc7a-42ff-9a01-809c31e1dc71)\r\nFTR Configs #58 / discover/group3 discover doc viewer flyout\r\naccessibility should use expected a11y attributes\r\n\r\nThis one is simple. Native to react `useId` implementation produces ids\r\nlike this: `:r3:` and when you attempt to use such ids with id selector\r\nthey're invalid . e.g. `document.querySelector('#:r3:')` throws an\r\nerror. A workaround is to use attribute selector\r\n`document.querySelector('[id=\":r3:\"]')`. This is the same problem as\r\nwe've seen before https://github.com/elastic/kibana/pull/191632","sha":"cf5d2e70da3af649bd97931c4e95eee954aa0bb3","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor"],"title":"[React@18 failing test] fix discover/group3 discover doc viewer flyout accessibility should use expected a11y attributes","number":196844,"url":"https://github.com/elastic/kibana/pull/196844","mergeCommit":{"message":"[React@18 failing test] fix discover/group3 discover doc viewer flyout accessibility should use expected a11y attributes (elastic#196844)\n\n## Summary\r\n\r\nWe're working on upgrading Kibana to React@18 (in Legacy Mode). There\r\nare a couple failing tests when running React@18 in Legacy mode and this\r\nis one of them\r\n\r\n\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/243743#01929ee7-11b8-41c3-af79-1437561a6ef0)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/243743/jobs/01929ee7-11b8-41c3-af79-1437561a6ef0/artifacts/01929f0a-dc7a-42ff-9a01-809c31e1dc71)\r\nFTR Configs #58 / discover/group3 discover doc viewer flyout\r\naccessibility should use expected a11y attributes\r\n\r\nThis one is simple. Native to react `useId` implementation produces ids\r\nlike this: `:r3:` and when you attempt to use such ids with id selector\r\nthey're invalid . e.g. `document.querySelector('#:r3:')` throws an\r\nerror. A workaround is to use attribute selector\r\n`document.querySelector('[id=\":r3:\"]')`. This is the same problem as\r\nwe've seen before https://github.com/elastic/kibana/pull/191632","sha":"cf5d2e70da3af649bd97931c4e95eee954aa0bb3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196844","number":196844,"mergeCommit":{"message":"[React@18 failing test] fix discover/group3 discover doc viewer flyout accessibility should use expected a11y attributes (elastic#196844)\n\n## Summary\r\n\r\nWe're working on upgrading Kibana to React@18 (in Legacy Mode). There\r\nare a couple failing tests when running React@18 in Legacy mode and this\r\nis one of them\r\n\r\n\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/243743#01929ee7-11b8-41c3-af79-1437561a6ef0)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/243743/jobs/01929ee7-11b8-41c3-af79-1437561a6ef0/artifacts/01929f0a-dc7a-42ff-9a01-809c31e1dc71)\r\nFTR Configs #58 / discover/group3 discover doc viewer flyout\r\naccessibility should use expected a11y attributes\r\n\r\nThis one is simple. Native to react `useId` implementation produces ids\r\nlike this: `:r3:` and when you attempt to use such ids with id selector\r\nthey're invalid . e.g. `document.querySelector('#:r3:')` throws an\r\nerror. A workaround is to use attribute selector\r\n`document.querySelector('[id=\":r3:\"]')`. This is the same problem as\r\nwe've seen before https://github.com/elastic/kibana/pull/191632","sha":"cf5d2e70da3af649bd97931c4e95eee954aa0bb3"}}]}] BACKPORT--> Co-authored-by: Anton Dosov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the missing
screenDescriptionandstarterPromptstoscreenContextRt