Refactor using DriverModel
#3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterKraus
commented
Sep 2, 2024
|
@AlexN7-Shepard It looks like you've added a new file |
… the lab this week
PeterKraus
commented
Oct 7, 2024
src/tomato_bronkhorst/__init__.py
Outdated
Comment on lines
7
to
10
| # you mentionned that the property map should be outside, check | ||
| # but also that the parameters were hard coded, for more I think you asked to handle this : | ||
| # here is a proposition for more flexibility : | ||
| class PropertyMap: |
There was a problem hiding this comment.
I don't see the benefit of having this as a Class, since there are no useful class methods in it. I'm not sure we'll ever need to add a property from within tomato...
src/tomato_bronkhorst/__init__.py
Outdated
Comment on lines
127
to
128
| else: | ||
| raise ValueError(f"Unknown device type: {device_type}. Expected 90 for MFC or 91 for PC.") |
There was a problem hiding this comment.
Syntax error due to bad indent here.
src/tomato_bronkhorst/__init__.py
Outdated
| ) | ||
| return attrs_dict | ||
|
|
||
| def _capabilities(self, **kwargs) -> set: |
There was a problem hiding this comment.
This should also be on the DeviceManager, and capabilities not _capabilities.
…red + some debugging, the code is now fully reachable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will refactor @AlexN7-Shepard's implementation using tomato's
DriverModel.Tasks:
Tasks