Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API documentation for /cryptos/{cryptoCode}/rpc #486

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SuperJMN
Copy link
Contributor

@SuperJMN SuperJMN commented Nov 25, 2024

Adds documentation for the API for this missing endpoint.

@SuperJMN SuperJMN changed the title Add documentation for /cryptos/{cryptoCode}/rpc Add API documentation for /cryptos/{cryptoCode}/rpc Nov 25, 2024
},
"security": [
{
"ApiKeyAuth": []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we never used this

"post": {
"summary": "Proxy RPC call to the underlying node",
"description": "Allows you to make RPC calls to the underlying cryptocurrency node (e.g., Bitcoin Core) via NBXplorer. This endpoint acts as a proxy, forwarding your RPC requests to the node and returning the node's responses.",
"tags": ["Node RPC Proxy"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blockchain

"summary": "Proxy RPC call to the underlying node",
"description": "Allows you to make RPC calls to the underlying cryptocurrency node (e.g., Bitcoin Core) via NBXplorer. This endpoint acts as a proxy, forwarding your RPC requests to the node and returning the node's responses.",
"tags": ["Node RPC Proxy"],
"parameters": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a $ref

}
},
"401": {
"description": "Unauthorized. Authentication failed.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look how I documented other errors, here 401 can be json-rpc-not-exposed

}
}
},
"403": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove

}
}
},
"500": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

"/cryptos/{cryptoCode}/node/rpc": {
"post": {
"summary": "Proxy RPC call to the underlying node",
"description": "Allows you to make RPC calls to the underlying cryptocurrency node (e.g., Bitcoin Core) via NBXplorer. This endpoint acts as a proxy, forwarding your RPC requests to the node and returning the node's responses.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants