Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add timestamp limits to getTransactions #473

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add timestamp limits to getTransactions #473

wants to merge 5 commits into from

Conversation

coval3nte
Copy link

No description provided.

@NicolasDorier
Copy link
Member

@coval3nte sorry for the slow feedback, concept ACK.
However can you:

  1. Use long? instead of long
  2. Rename from/toUnixTimestamp to fromSeen/toSeen
  3. Document those in the Docs/API.md?

NicolasDorier
NicolasDorier reviewed Oct 30, 2024
View reviewed changes
docs/API.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasDorier NicolasDorier NicolasDorier left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coval3nte @NicolasDorier