Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add citations for damping parameters #104

Merged
merged 8 commits into from
Sep 29, 2024
Merged

Add citations for damping parameters #104

merged 8 commits into from
Sep 29, 2024

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Sep 28, 2024

Closes #90

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 1.19760% with 330 lines in your changes missing coverage. Please review.

Project coverage is 46.02%. Comparing base (3a50cbd) to head (63a94e2).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
src/dftd3/param.f90 0.82% 9 Missing and 231 partials ⚠️
src/dftd3/citation.f90 0.00% 60 Missing ⚠️
app/driver.f90 8.69% 20 Missing and 1 partial ⚠️
app/cli.f90 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   48.63%   46.02%   -2.62%     
==========================================
  Files          34       25       -9     
  Lines        3707     2866     -841     
  Branches     1518     1294     -224     
==========================================
- Hits         1803     1319     -484     
+ Misses       1207      970     -237     
+ Partials      697      577     -120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/dftd3/param.f90 Outdated Show resolved Hide resolved
src/dftd3/param.f90 Outdated Show resolved Hide resolved
src/dftd3/param.f90 Outdated Show resolved Hide resolved
src/dftd3/param.f90 Outdated Show resolved Hide resolved
src/dftd3/param.f90 Outdated Show resolved Hide resolved
@awvwgk awvwgk merged commit 202a6ba into dftd3:main Sep 29, 2024
41 of 43 checks passed
@awvwgk awvwgk deleted the citation branch September 29, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add citations for parameters
1 participant