Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in sktwocnt for the global hybrid B3LYP #75

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

vanderhe
Copy link
Member

Bug fix for the fraction $\alpha$ of Fock-type exchange not being correctly propagated to the two-center integration routines, when using the global hybrid functional B3LYP. This unfortunately necessitates to recalculate the associated regression tests and to create a bug fix release as soon as possible.

@vanderhe vanderhe added the bugfix Fixes a bug label Apr 19, 2024
sktwocnt/lib/twocnt.f90 Show resolved Hide resolved
sktwocnt/lib/twocnt.f90 Show resolved Hide resolved
sktwocnt/prog/input.f90 Show resolved Hide resolved
Copy link
Member

@bhourahine bhourahine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but obviously needs a release discussion at the next dev meeting.

@bhourahine bhourahine merged commit 097a928 into dftbplus:main Apr 19, 2024
3 checks passed
@vanderhe vanderhe deleted the b3lypFix branch April 19, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants