fix: update internal mrf form language and align button behaviour #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🛡️ 1 Security Vulnerabilities You may view the full report here. |
vincentauger
requested changes
Nov 19, 2024
database/migrations/2024_11_14_184759_add_ogl_question_to_manuscript_records_table.php
Show resolved
Hide resolved
resources/src/models/ManuscriptRecord/views/ManuscriptRecordFormView.vue
Outdated
Show resolved
Hide resolved
Looks Good Co-authored-by: Vincent Auger <[email protected]> Signed-off-by: Mathew E <[email protected]>
|
🛡️ 1 Security Vulnerabilities You may view the full report here. |
|
🛡️ 1 Security Vulnerabilities You may view the full report here. |
|
🛡️ 1 Security Vulnerabilities You may view the full report here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
ManuscriptRecordmodel and its related components, controllers, and resources which manage thedo_not_apply_oglvariable. These updates reflect the change in language to the Report Licensing question found within the DFO Publication MRF form.Frontend Changes
Backend Changes
do_not_apply_oglupdated toapply_oglto reflect the new behaviour of the question.apply_oglinadd_ogl_question_to_manuscript_records_tableswitched to True.Testing
ManuscriptRecordTestto False reflect change in context ofapply_ogl.