Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add OGL question to DFO pub MRF #824

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

vincentauger
Copy link
Member

This pull request includes several changes to the ManuscriptRecord model and its related components, controllers, and resources. The changes introduce new fields and validation rules, update existing fields, and add new migration files to support these updates. Additionally, there are updates to the front-end components to reflect these changes.

Backend Changes:

  • Added new fields do_not_apply_ogl and no_ogl_explanation to the ManuscriptRecord model and updated the corresponding validation rules and attributes. [1] [2]
  • Renamed the additional_information field to public_interest_information in the ManuscriptRecord model and updated the relevant methods and resources. (Fb21f90bL31R31, app/Http/Resources/ManuscriptRecordResource.phpL34-R37)
  • Updated the ManuscriptRecordController to use Auth::id() instead of auth()->id() for consistency.
  • Added a new migration file to update the manuscript_records table with the new fields and renamed the existing field.

Frontend Changes:

  • Updated QuestionEditor.vue to include a new hideEditor prop and conditionally render the editor based on this prop. [1] [2]
  • Modified ManuscriptRecordFormView.vue to include the new fields and validation rules, and updated the event names for consistency. [1] [2] [3] [4] [5] [6] [7]
  • Added new localization strings for the new fields and updated existing ones in both English and French localization files. [1] [2]

Testing:

  • Added a new test to ensure that a user cannot submit their manuscript for review without providing an explanation if they do not want to apply for an OGL.

@vincentauger vincentauger linked an issue Nov 14, 2024 that may be closed by this pull request
Copy link

⚠️ 1 Checks Failed!

🛡️ 1 Security Vulnerabilities
🚀 0 Performance Issues
🐛 0 Reliability Issues

You may view the full report here.

@vincentauger vincentauger merged commit f9931e5 into main Nov 14, 2024
3 of 4 checks passed
@vincentauger vincentauger deleted the 796-add-licensing-question-to-internal-mrf branch November 14, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add licensing question to internal MRF
1 participant