Orcid integration employment - ready for prod progress #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the UI for connecting ORCID accounts in the ManageAuthorOrcidCard component. It adds new text and links to provide more information about the benefits of connecting an ORCID account. Additionally, it improves the layout and styling of the component.
Great feature added to the last laravel template - allows to run all required dev tool from one command and in parallel. Requires concurrently (node) package to be installed if used.
|
🛡️ 1 Security Vulnerabilities You may view the full report here. |
|
✔️ All Checks Passed! 🛡️ 0 Security Vulnerabilities You may view the full report here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature isn't complete but it's been too long on prod; merging as current code is ready and will add further functionality next week.
This pull request includes several changes, primarily focusing on the addition of new data classes for the ORCID integration, controller updates, and minor code style adjustments.
New Data Classes for ORCID Integration:
AddressDataclass to handle address-related data (app/Http/Integrations/Orcid/Data/AddressData.php).DateDataclass to manage date-related data (app/Http/Integrations/Orcid/Data/DateData.php).DisambiguatedOrganizationDataclass for handling disambiguated organization data (app/Http/Integrations/Orcid/Data/DisambiguatedOrganizationData.php).EmploymentDataclass to manage employment-related data (app/Http/Integrations/Orcid/Data/EmploymentData.php).app/Http/Integrations/Orcid/Data/ExternalIdData.php,app/Http/Integrations/Orcid/Data/ExternalIdsData.php,app/Http/Integrations/Orcid/Data/TimestampData.php,app/Http/Integrations/Orcid/Data/UrlData.php). [1] [2] [3] [4]Controller Updates:
AuthorEmploymentControllerto manage author employment resources, including methods for listing, storing, showing, updating, and deleting employments (app/Http/Controllers/AuthorEmploymentController.php).ValidationExceptionimport fromPasswordResetLinkController(app/Http/Controllers/Auth/PasswordResetLinkController.php).Code Style Adjustments:
DownloadLatestRORData.php(app/Actions/ROR/DownloadLatestRORData.php).SyncRORData.php(app/Actions/ROR/SyncRORData.php).SyncRORData.php(app/Actions/ROR/SyncRORData.php). [1] [2]Enum Updates:
ORCIDAuthScopeand updated its namespace (app/Http/Integrations/Orcid/Enums/ORCIDAuthScope.php).app/Http/Integrations/Orcid/Enums/ActivitiesScopeEndpoint.php,app/Http/Integrations/Orcid/Enums/ActivitiesScopeListEndpoint.php). [1] [2]