Filament Support Panel #778
Conversation
|
✔️ All Checks Passed! 🛡️ 0 Security Vulnerabilities You may view the full report here. |
|
✔️ All Checks Passed! 🛡️ 0 Security Vulnerabilities You may view the full report here. |
|
✔️ All Checks Passed! 🛡️ 0 Security Vulnerabilities You may view the full report here. |
app/Models/User.php
Outdated
| */ | ||
| public function canAccessPanel(Panel $panel): bool | ||
| { | ||
| return $this->hasRole('admin'); |
There was a problem hiding this comment.
hey, we should use permissions here instead, like 'view_librarium' and add this new permission to the author role in the role and permission seeder.
app/Policies/UserPolicy.php
Outdated
| @@ -16,7 +16,7 @@ class UserPolicy | |||
| */ | |||
| public function viewAny(User $user) | |||
| { | |||
| return false; | |||
| return $user->hasRole('admin'); | |||
app/Policies/UserPolicy.php
Outdated
| @@ -49,7 +49,7 @@ public function create(User $user) | |||
| public function update(User $user, User $model) | |||
| { | |||
| // a user can update their own profile | |||
| return $user->id === $model->id; | |||
| return $user->id === $model->id or $user->hasRole('admin'); | |||
There was a problem hiding this comment.
use permission and split in two lines
if($user->can('update_all_users') return true
...| ->default() | ||
| ->id('librarium') | ||
| ->path('librarium') | ||
| ->login() |
There was a problem hiding this comment.
Let's implement our own login page here, use the base filament page and copy it in App\Filament\Pages\Auth and refactor so that it uses the same throttling values as our main login flow.
|
🛡️ 1 Security Vulnerabilities You may view the full report here. |
| @@ -47,6 +47,8 @@ public function run() | |||
| Permission::findOrCreate('view_telescope'), | |||
| Permission::findOrCreate('view_horizon'), | |||
| Permission::findOrCreate('view_pulse'), | |||
| Permission::findOrCreate('view_any_user'), | |||
There was a problem hiding this comment.
this should just be view_admin_panel to give access to the filament admin panel, the user view and user update should be based on the user policy.
vincentauger
force-pushed
the
filament
branch
from
1ccf019
to
c269d73
Compare
|
✔️ All Checks Passed! 🛡️ 0 Security Vulnerabilities You may view the full report here. |
|
✔️ All Checks Passed! 🛡️ 0 Security Vulnerabilities You may view the full report here. |
|
✔️ All Checks Passed! 🛡️ 0 Security Vulnerabilities You may view the full report here. |
|
✔️ All Checks Passed! 🛡️ 0 Security Vulnerabilities You may view the full report here. |
|
✔️ All Checks Passed! 🛡️ 0 Security Vulnerabilities You may view the full report here. |
|
✔️ All Checks Passed! 🛡️ 0 Security Vulnerabilities You may view the full report here. |
…g to match core login
…g to match core login
vincentauger
force-pushed
the
filament
branch
from
9cce5e9
to
43faf29
Compare
|
✔️ All Checks Passed! 🛡️ 0 Security Vulnerabilities You may view the full report here. |
Implementation of a basic FilamentPHP Support Panel.
Features: