fix: orcid icon guideline

dfo-osdt · Nov 14, 2024 · b61823a · b61823a
1 parent d71214f
commit b61823a
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 9 deletions.
diff --git a/resources/src/auto-imports.d.ts b/resources/src/auto-imports.d.ts
@@ -332,6 +332,7 @@ declare global {
   export type { Component, ComponentPublicInstance, ComputedRef, DirectiveBinding, ExtractDefaultPropTypes, ExtractPropTypes, ExtractPublicPropTypes, InjectionKey, PropType, Ref, MaybeRef, MaybeRefOrGetter, VNode, WritableComputedRef } from 'vue'
   import('vue')
 }
+
 // for vue template auto import
 import { UnwrapRef } from 'vue'
 declare module 'vue' {
@@ -652,4 +653,4 @@ declare module 'vue' {
     readonly watchWithFilter: UnwrapRef<typeof import('@vueuse/core')['watchWithFilter']>
     readonly whenever: UnwrapRef<typeof import('@vueuse/core')['whenever']>
   }
-}
+}
diff --git a/resources/src/components/OrcidAvatar.vue b/resources/src/components/OrcidAvatar.vue
@@ -1,7 +1,7 @@
 <script setup lang="ts"></script>
 
 <template>
-  <q-avatar icon="img:/assets/orcid/orcid.logo.icon.svg" />
+  <q-avatar icon="img:/assets/orcid/orcid.logo.icon.svg" aria-label="ORCID iD logo" />
 </template>
 
 <style scoped></style>
diff --git a/resources/src/components/OrcidIcon.vue b/resources/src/components/OrcidIcon.vue
@@ -1,7 +1,11 @@
 <script setup lang="ts"></script>
 
 <template>
-  <q-icon name="img:/assets/orcid/orcid.logo.icon.svg" />
+  <q-icon
+    name="img:/assets/orcid/orcid.logo.icon.svg"
+    size="16px"
+    alt="ORCID iD logo"
+  />
 </template>
 
 <style scoped></style>
diff --git a/resources/src/models/ManuscriptRecord/components/ManuscriptList.vue b/resources/src/models/ManuscriptRecord/components/ManuscriptList.vue
@@ -1,8 +1,9 @@
 <script setup lang="ts">
 import type { ManuscriptRecordSummaryResource } from '../ManuscriptRecord'
-import ManuscriptTypeBadge from './ManuscriptTypeBadge.vue'
-import ManuscriptStatusBadge from './ManuscriptStatusBadge.vue'
+import OrcidIcon from '@/components/OrcidIcon.vue'
 import DeleteManuscriptButton from './DeleteManuscriptButton.vue'
+import ManuscriptStatusBadge from './ManuscriptStatusBadge.vue'
+import ManuscriptTypeBadge from './ManuscriptTypeBadge.vue'
 
 defineProps<{
   manuscripts: ManuscriptRecordSummaryResource[]
@@ -46,10 +47,8 @@ function goToManuscript(manuscript: ManuscriptRecordSummaryResource) {
                   .manuscript_authors"
                 :key="item.data.id"
               >
-                <q-img
+                <OrcidIcon
                   v-if="item.data.author?.data.orcid"
-                  src="/assets/orcid/orcid.logo.icon.svg"
-                  width="15px"
                 />
                 {{ item.data.author?.data.last_name }},
                 {{ item.data.author?.data.first_name }}

diff --git a/resources/src/models/PublicationAuthor/components/PublicationAuthorChip.vue b/resources/src/models/PublicationAuthor/components/PublicationAuthorChip.vue
@@ -1,6 +1,6 @@
 <script setup lang="ts">
-import OrcidAvatar from '../../../components/OrcidAvatar.vue'
 import type { PublicationAuthorResource } from '../PublicationAuthor'
+import OrcidAvatar from '../../../components/OrcidAvatar.vue'
 
 const props = withDefaults(
   defineProps<{