Add iter_messages and iter_enums to Descriptor
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions make it possible to discover what messages and enums are available in the descriptor set when you don't know their names ahead of time. Co-authored-by: Nikhil Benesch <[email protected]>
benesch
added a commit
to benesch/materialize
that referenced
this pull request
Aug 22, 2021
We forked serde-protobuf library to add one method to improve an error message. Empirically we have not been keeping up with maintenance of our fork, so it's time to ditch the fork. This commit swaps our fork for the latest official serde-protobuf release. I left a TODO to restore the error message improvement if the patch [0] from our fork is accepted upstream. Notably, this commit removes the last usage of failure from our codebase. [0]: dflemstr/serde-protobuf#9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @dflemstr, we've been carrying these functions around in our fork of this package at @MaterializeInc for a while. Figured it was time to upstream them. Any objection?
These functions make it possible to discover what messages and enums
are available in the descriptor set when you don't know their names
ahead of time.