Skip to content

Commit

Permalink
Clean up build step (#39)
Browse files Browse the repository at this point in the history
* Clean up build step

* Cleaning
  • Loading branch information
lmuntaner authored Sep 13, 2023
1 parent cf510ed commit 421790b
Show file tree
Hide file tree
Showing 4 changed files with 1,374 additions and 6,580 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,5 @@
build/
dist/
node_modules/
.parcel-cache/

**/*.rs.bk
7 changes: 4 additions & 3 deletions esbuild.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,10 @@ const script = await esbuild.build({
NodeResolve.NodeResolvePlugin({
extensions: [".ts", ".js"],
onResolved: (resolved) => {
// We need to exclude node-hid but not hw-transport-node-hid-noevents for
// the bindings library to work properly.
// https://github.com/TooTallNate/node-bindings/issues/65#issuecomment-637495802
// We want all node modules in the same bundle.
// Except for the node-hid module which needs to be outside to work properly.
// There is another library with the name "hw-transport-node-hid-noevents"
// That's why need such a fine-grained check.
if (
resolved.includes("node_modules") &&
resolved.includes("node-hid") &&
Expand Down
Loading

0 comments on commit 421790b

Please sign in to comment.