-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archive old Motoko examples #996
Conversation
Why do we want to move these examples under |
@chenyan-dfinity We're cleaning up the examples repo and removing examples that are duplicates, outdated and not maintained, or do not showcase a meaningful app. Some of these are small Motoko examples (actor-reference and counter are two examples) that are duplicated across the Motoko docs in several places, and it is not meaningful for them to have their example in this repo that will soon contain more complex and comprehensive app samples. Is there an easy path to migrating these examples to the new URLs in Playground? |
It's easy to update the URL in the playground, and I agree that most of the apps here are out dated. But small/minimal examples do have values, in particular |
Ideally, all examples should have a frontend, so these duplicates without a frontend are being archived in favor of the versions with a frontend. |
I think it's the contrary, we want to have everything mentioned on the docs page to be available in the example repo, so that people can try out.
I think some examples may benefit without having a frontend, so that readers don't get distracted. A few examples come to mind: http outcalls and pub-sub. Having a frontend can make it harder to see the underlying concept. |
What would your proposed change be for this PR? |
If the goal is for each example in this repository to have a direct use case, maybe we could move the Motoko-specific language feature examples to the |
I may be missing context, is there a doc to discuss the examples revamp? We can discuss from there. |
No, there is not a currently a doc, this was a task given to me as part of the Web IDE project. The task was to take an inventory of our current examples, determine which examples showcased full applications (frontend/backend), which could be improved to become full applications (i.e., add a frontend), and which examples were duplicates or outdated. The idea is that each example we have in the repo (ideally) becomes a project template for the Web IDE and users can pick one when they enter the Web IDE. There are also plans to create several new examples that showcase use cases for everyday activities, such as writing, art, fitness, etc. For some examples, such as the I agree with Ryan's idea that it might be better to move the Motoko-specific examples to the Motoko repo and maintain them there, rather than archive them in this repo. |
Web IDE can cherrypick examples from this repo, it doesn't have to show all projects from here. When the users read the Moving them to the Motoko repo would make it harder to find the examples, e.g., which examples stay in the example repo and which ones stay in Motoko repo? Examples repo is a collection of projects satisfying different needs. It cannot be only for the Web IDE gallery. We even have C and raw wasm examples here. In terms of deprecation, I feel like many of the examples need a rewrite, instead of archiving. Let me comment on the spreadsheet. |
Overview
Why do we need this feature? What are we trying to accomplish?
Requirements
What requirements are necessary to consider this problem solved?
Considered Solutions
What solutions were considered?
Recommended Solution
What solution are you recommending? Why?
Considerations
What impact will this change have on security, performance, users (e.g. breaking changes) or the team (e.g. maintenance costs)?