Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ic-pos to motoko examples #614

Merged

Conversation

kristoferlund
Copy link
Contributor

@kristoferlund kristoferlund commented Sep 12, 2023

Overview

This PR adds the ckBTC Point of Sale example app (Motoko) to the repository. The original repo can be found here: https://github.com/kristoferlund/ic-pos

IC-POS is an experimental app to demonstrate a real world use case for ckBTC on the Internet Computer. It is a simple Point of Sale app that allows users to accept ckBTC payments.

For more details about IC-POS, see the README.

@kristoferlund kristoferlund requested a review from a team as a code owner September 12, 2023 11:40
@ghost
Copy link

ghost commented Sep 12, 2023

Dear @kristoferlund,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1.

If you decide to agree with it, please visit this issue and read the instructions there.

— The DFINITY Foundation

Footnotes

  1. Contributor License Agreement

@ghost
Copy link

ghost commented Sep 12, 2023

Dear @kristoferlund,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1.

If you decide to agree with it, please visit this issue and read the instructions there.

— The DFINITY Foundation

Footnotes

  1. Contributor License Agreement

@letmejustputthishere
Copy link
Member

hey @kristoferlund , thank you for adding this example! very happy to see community contributions 🎉
i'll create PRs for potential changes in your repo instead of on this PR. do you have a good flow in mind to keep this example updated with future changes from the upstream repo?

@letmejustputthishere
Copy link
Member

@kristoferlund see here
kristoferlund/ic-pos#4

@kristoferlund
Copy link
Contributor Author

Looks great @letmejustputthishere, thanks! Have been on vacation but am back in business now. I'll take a closer look and merge the coming days.

I have not considered a good flow keeping the main repo and dfinity-examples in sync. Don't know to what extent that is possible. As I am not planning any more development on ic-pos for now, this time I will copypaste your changes between repos.

@letmejustputthishere
Copy link
Member

@kristoferlund if you merge this with upstream i think we are good to go :)

are there any changes that need to be done here dfinity/portal#1892?

@kristoferlund
Copy link
Contributor Author

@letmejustputthishere this PR now updated with latest changes.

are there any changes that need to be done here dfinity/portal#1892?

I'll make a PR to make sure docs reflect the changes.

@letmejustputthishere letmejustputthishere merged commit baa6111 into dfinity:master Oct 2, 2023
@kristoferlund kristoferlund deleted the add/ic-pos-example branch October 2, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants