Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add blueprints tag #67

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Feat/add blueprints tag #67

merged 3 commits into from
Jan 19, 2024

Conversation

rifisdfds
Copy link
Contributor

Describe your changes

This PR adds a dfds.automation.name default tag. This is so that it can be identified as a "blueprint" explicitly rather than implicitly via other tags. This will be useful for identifying deployed "blueprint" resources.

Issue ticket number and link

Checklist before requesting a review

  • I have tested changes in my sandbox
  • I have added the needed changes in the test/qa folder to apply my changes in QA.
  • I have rebased the code to main (or merged in the latest from main)

Is it a new release?

  • Apply a release tag release:(major|minor|patch), following semantic versioning in this guide or norelease if there is no changes to the Terraform code

@rifisdfds rifisdfds added the release:minor Semantic versioning minor release label label Jan 17, 2024
@rifisdfds rifisdfds requested a review from samidbb January 17, 2024 11:19
samidbb
samidbb previously approved these changes Jan 18, 2024
@samidbb samidbb self-requested a review January 18, 2024 15:51
locals.tf Outdated Show resolved Hide resolved
@samidbb samidbb self-requested a review January 18, 2024 15:52
Copy link
Contributor

@samidbb samidbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah let's try it

@rifisdfds rifisdfds merged commit 014db0c into main Jan 19, 2024
4 checks passed
@rifisdfds rifisdfds deleted the feat/add-blueprints-tag branch January 19, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:minor Semantic versioning minor release label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants