Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ensure-only-central-backup-is-used #49

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

samidbb
Copy link
Contributor

@samidbb samidbb commented Dec 18, 2023

Describe your changes

Cannot set backup retention to 0 while dfds.data.backup is set to true (central backup is activated). API suggests setting this to blank when the backup has been taken over by the AWS Backup

Issue ticket number and link

bug

Checklist before requesting a review

  • I have tested changes in my sandbox
  • I have added the needed changes in the test/qa folder to apply my changes in QA.
  • I have rebased the code to main (or merged in the latest from main)

Is it a new release?

  • Apply a release tag release:(major|minor|patch), following semantic versioning in this guide or norelease if there is no changes to the Terraform code

@samidbb samidbb added the release:patch Semantic versioning patch release label label Dec 18, 2023
@samidbb samidbb merged commit 643bab2 into main Dec 18, 2023
1 of 2 checks passed
@samidbb samidbb deleted the fix/ensure-only-central-backup-is-used branch December 18, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Semantic versioning patch release label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants