Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for adding proper tags #45

Merged
merged 8 commits into from
Dec 15, 2023
Merged

Support for adding proper tags #45

merged 8 commits into from
Dec 15, 2023

Conversation

samidbb
Copy link
Contributor

@samidbb samidbb commented Dec 13, 2023 •
edited
Loading

Describe your changes

Issue ticket number and link

https://github.com/dfds/cloudplatform/issues/2342

Checklist before requesting a review

  • I have tested changes in my sandbox
  • I have added the needed changes in the test/qa folder to apply my changes in QA.
  • I have rebased the code to main (or merged in the latest from main)

Is it a new release?

  • Apply a release tag release:(major|minor|patch), following semantic versioning in this guide or norelease if there is no changes to the Terraform code

@samidbb samidbb changed the title wip Support for adding proper tags Dec 13, 2023
@samidbb samidbb added the release:minor Semantic versioning minor release label label Dec 14, 2023
@samidbb samidbb marked this pull request as ready for review December 14, 2023 14:42
avnes
avnes approved these changes Dec 15, 2023
View reviewed changes
tests/instance/main.tf Outdated Show resolved Hide resolved
@samidbb samidbb merged commit 20b36be into main Dec 15, 2023
9 checks passed
@samidbb samidbb deleted the feature/apply-default-tags branch December 15, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avnes avnes avnes approved these changes

Assignees
No one assigned
Labels
release:minor Semantic versioning minor release label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samidbb @avnes