Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/revert engine info data #41

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Conversation

samidbb
Copy link
Contributor

@samidbb samidbb commented Dec 12, 2023

Describe your changes

Getting weird errors when supplying value
engine_version = "15"

│ Error: multiple RDS engine versions ([{ │ DBEngineDescription: "PostgreSQL", │ DBEngineVersionDescription: "PostgreSQL 15.2-R2", │ DBParameterGroupFamily: "postgres15", │ Engine: "postgres", │ EngineVersion: "15.2", │ ExportableLogTypes: ["postgresql","upgrade"], │ MajorEngineVersion: "15", │ Status: "available", │ SupportedCACertificateIdentifiers: [ │ "rds-ca-2019", │ "rds-ca-ecc384-g1", │ "rds-ca-rsa4096-g1", │ "rds-ca-rsa2048-g1" │ ], │ SupportedFeatureNames: ["Lambda","s3Export","s3Import"], │ SupportsBabelfish: false, │ SupportsCertificateRotationWithoutRestart: true, │ SupportsGlobalDatabases: false, │ SupportsIntegrations: false, │ SupportsLocalWriteForwarding: false, │ SupportsLogExportsToCloudwatchLogs: true, │ SupportsParallelQuery: false, │ SupportsReadReplica: true, │ ValidUpgradeTarget: [ │ { │ AutoUpgrade: false, │ Description: "PostgreSQL 15.3-R2", │ Engine: "postgres", │ EngineVersion: "15.3", │ IsMajorVersionUpgrade: false │ }, │ { │ AutoUpgrade: false, │ Description: "PostgreSQL 15.4-R3", │ Engine: "postgres", │ EngineVersion: "15.4", │ IsMajorVersionUpgrade: false │ }, │ { │ AutoUpgrade: false, │ Description: "PostgreSQL 15.5-R1", │ Engine: "postgres", │ EngineVersion: "15.5", │ IsMajorVersionUpgrade: false │ }, │ { │ AutoUpgrade: false, │ Description: "PostgreSQL 16.1-R1", │ Engine: "postgres", │ EngineVersion: "16.1", │ IsMajorVersionUpgrade: true │ } │ ] │ } { │ DBEngineDescription: "PostgreSQL", │ DBEngineVersionDescription: "PostgreSQL 15.3-R2", │ DBParameterGroupFamily: "postgres15", │ Engine: "postgres", │ EngineVersion: "15.3", │ ExportableLogTypes: ["postgresql","upgrade"], │ MajorEngineVersion: "15", │ Status: "available", │ SupportedCACertificateIdentifiers: [ │ "rds-ca-2019", │ "rds-ca-ecc384-g1", │ "rds-ca-rsa4096-g1", │ "rds-ca-rsa2048-g1" │ ], │ SupportedFeatureNames: ["Lambda","s3Export","s3Import"], │ SupportsBabelfish: false, │ SupportsCertificateRotationWithoutRestart: true, │ SupportsGlobalDatabases: false, │ SupportsIntegrations: false, │ SupportsLocalWriteForwarding: false, │ SupportsLogExportsToCloudwatchLogs: true, │ SupportsParallelQuery: false, │ SupportsReadReplica: true, │ ValidUpgradeTarget: [{ │ AutoUpgrade: false, │ Description: "PostgreSQL 15.4-R3", │ Engine: "postgres", │ EngineVersion: "15.4", │ IsMajorVersionUpgrade: false │ },{ │ AutoUpgrade: false, │ Description: "PostgreSQL 15.5-R1", │ Engine: "postgres", │ EngineVersion: "15.5", │ IsMajorVersionUpgrade: false │ },{ │ AutoUpgrade: false, │ Description: "PostgreSQL 16.1-R1", │ Engine: "postgres", │ EngineVersion: "16.1", │ IsMajorVersionUpgrade: true │ }] │ } { │ DBEngineDescription: "PostgreSQL", │ DBEngineVersionDescription: "PostgreSQL 15.4-R3", │ DBParameterGroupFamily: "postgres15", │ Engine: "postgres", │ EngineVersion: "15.4", │ ExportableLogTypes: ["postgresql","upgrade"], │ MajorEngineVersion: "15", │ Status: "available", │ SupportedCACertificateIdentifiers: [ │ "rds-ca-2019", │ "rds-ca-ecc384-g1", │ "rds-ca-rsa4096-g1", │ "rds-ca-rsa2048-g1" │ ], │ SupportedFeatureNames: ["Lambda","s3Export","s3Import"], │ SupportsBabelfish: false, │ SupportsCertificateRotationWithoutRestart: true, │ SupportsGlobalDatabases: false, │ SupportsIntegrations: false, │ SupportsLocalWriteForwarding: false, │ SupportsLogExportsToCloudwatchLogs: true, │ SupportsParallelQuery: false, │ SupportsReadReplica: true, │ ValidUpgradeTarget: [{ │ AutoUpgrade: false, │ Description: "PostgreSQL 15.5-R1", │ Engine: "postgres", │ EngineVersion: "15.5", │ IsMajorVersionUpgrade: false │ },{ │ AutoUpgrade: false, │ Description: "PostgreSQL 16.1-R1", │ Engine: "postgres", │ EngineVersion: "16.1", │ IsMajorVersionUpgrade: true │ }] │ } { │ DBEngineDescription: "PostgreSQL", │ DBEngineVersionDescription: "PostgreSQL 15.5-R1", │ DBParameterGroupFamily: "postgres15", │ Engine: "postgres", │ EngineVersion: "15.5", │ ExportableLogTypes: ["postgresql","upgrade"], │ MajorEngineVersion: "15", │ Status: "available", │ SupportedCACertificateIdentifiers: [ │ "rds-ca-2019", │ "rds-ca-ecc384-g1", │ "rds-ca-rsa4096-g1", │ "rds-ca-rsa2048-g1" │ ], │ SupportedFeatureNames: ["Lambda","s3Export","s3Import"], │ SupportsBabelfish: false, │ SupportsCertificateRotationWithoutRestart: true, │ SupportsGlobalDatabases: false, │ SupportsIntegrations: false, │ SupportsLocalWriteForwarding: false, │ SupportsLogExportsToCloudwatchLogs: true, │ SupportsParallelQuery: false, │ SupportsReadReplica: true, │ ValidUpgradeTarget: [{ │ AutoUpgrade: false, │ Description: "PostgreSQL 16.1-R1", │ Engine: "postgres", │ EngineVersion: "16.1", │ IsMajorVersionUpgrade: true │ }] │ }]) match the criteria │ │ with module.rds_instance_test.data.aws_rds_engine_version.default, │ on ../../data.tf line 1, in data "aws_rds_engine_version" "default": │ 1: data "aws_rds_engine_version" "default" {

This has been fixed in previous version. Therefore reverting the change. Another benefit from using the previous version was it clearly stated what the expected value in engine version would in the plan. Not after apply!

``

Issue ticket number and link

bug found during testing

Checklist before requesting a review

  • I have tested changes in my sandbox
    - [ ] I have added the needed changes in the test/qa folder to apply my changes in QA.
  • I have rebased the code to main (or merged in the latest from main)

Is it a new release?

  • Apply a release tag release:(major|minor|patch), following semantic versioning in this guide or norelease if there is no changes to the Terraform code

@samidbb samidbb added the release:patch Semantic versioning patch release label label Dec 13, 2023
@samidbb samidbb merged commit b666708 into main Dec 13, 2023
1 check passed
@samidbb samidbb deleted the chore/revert-engine-info-data branch December 13, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Semantic versioning patch release label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants