Merge pull request #12 from dfds/minor-fixes

README.md

@@ -126,7 +126,7 @@ Terraform module for AWS RDS instances
 | <a name="input_is_serverless"></a> [is\_serverless](#input\_is\_serverless) | n/a | `bool` | `false` | no |
 | <a name="input_kms_key_id"></a> [kms\_key\_id](#input\_kms\_key\_id) | The ARN for the KMS encryption key. If creating an encrypted replica, set this to the destination KMS ARN. If storage\_encrypted is set to true and kms\_key\_id is not specified the default KMS key created in your account will be used. Be sure to use the full ARN, not a key alias. | `string` | `null` | no |
 | <a name="input_license_model"></a> [license\_model](#input\_license\_model) | License model information for this DB instance. Optional, but required for some DB engines, i.e. Oracle SE1 | `string` | `null` | no |
-| <a name="input_maintenance_window"></a> [maintenance\_window](#input\_maintenance\_window) | The window to perform maintenance in. Syntax: 'ddd:hh24:mi-ddd:hh24:mi'. Eg: 'Mon:00:00-Mon:03:00' | `string` | `"Sat:21:00-Sun:01:00"` | no |
+| <a name="input_maintenance_window"></a> [maintenance\_window](#input\_maintenance\_window) | The window to perform maintenance in. Syntax: 'ddd:hh24:mi-ddd:hh24:mi'. Eg: 'Mon:00:00-Mon:03:00' | `string` | `"Sat:18:00-Sat:20:00"` | no |
 | <a name="input_major_engine_version"></a> [major\_engine\_version](#input\_major\_engine\_version) | Specifies the major version of the engine that this option group should be associated with | `string` | `"14"` | no |
 | <a name="input_manage_master_user_password"></a> [manage\_master\_user\_password](#input\_manage\_master\_user\_password) | Set to true to allow RDS to manage the master user password in Secrets Manager | `bool` | `true` | no |
 | <a name="input_master_user_secret_kms_key_id"></a> [master\_user\_secret\_kms\_key\_id](#input\_master\_user\_secret\_kms\_key\_id) | The key ARN, key ID, alias ARN or alias name for the KMS key to encrypt the master user password secret in Secrets Manager.<br>  If not specified, the default KMS key for your Amazon Web Services account is used. | `string` | `null` | no |

tests/instance/main.tf

@@ -24,7 +24,6 @@ module "rds_instance_test" {
   source     = "../../"
   identifier = local.name
 
-
   instance_class         = "db.t3.micro"
   multi_az               = true
   username               = "instance_user"
@@ -37,7 +36,7 @@ module "rds_instance_test" {
   publicly_accessible = true
 
   subnet_ids        = concat(module.vpc.public_subnets)
-  allocated_storage = 100
+  allocated_storage = 5
 
   enabled_cloudwatch_logs_exports        = ["upgrade", "postgresql"]
   cloudwatch_log_group_retention_in_days = 1
@@ -47,14 +46,15 @@ module "rds_instance_test" {
   include_proxy       = true
   proxy_debug_logging = true
 
-  monitoring_interval = 60
+  enhanced_monitoring_interval = 60
 
   allow_major_version_upgrade = true # default ?
   major_engine_version        = 16
 
 }
 
 
+
 ################################################################################
 # Supporting Resources
 ################################################################################

variables.tf

@@ -280,10 +280,10 @@ variable "maintenance_window" {
   description = "The window to perform maintenance in. Syntax: 'ddd:hh24:mi-ddd:hh24:mi'. Eg: 'Mon:00:00-Mon:03:00'"
   type        = string
   #   default     = null
-  default = "Sat:21:00-Sun:01:00" # This is adjusted in accordance with AWS Backup schedule, see info here: https://wiki.dfds.cloud/en/playbooks/aws-backup/aws-backup-getting-started
+  default = "Sat:18:00-Sat:20:00" # This is adjusted in accordance with AWS Backup schedule, see info here: https://wiki.dfds.cloud/en/playbooks/aws-backup/aws-backup-getting-started
 }
-# Continuous backup takes place between 1 and 5 AM UTC.
-# Snapshot backups take place between 3 and 7 AM UTC.
+# Continuous backup takes place between 8 PM and 5 AM UTC.
+# Snapshot backups take place between 3 AM and 7 AM UTC.
 
 variable "blue_green_update" {
   description = "Enables low-downtime updates using RDS Blue/Green deployments."