Feature/reset food saturation #903
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
race condition plz add mutex |
CJMustard1452
suggested changes
Jul 24, 2024
didntpot
suggested changes
Jul 24, 2024
| @@ -65,6 +65,14 @@ func (m *hungerManager) Reset() { | |||
| m.mu.Unlock() | |||
| } | |||
|
|
|||
| // ResetExhaustion resets the exhaustion level of the player to 0. | |||
| // Prevents the player food level decrease after non cancelling the food loss | |||
| func (m *hungerManager) resetExhaustion() { | |||
There was a problem hiding this comment.
this function cause race condition plz fix
CJMustard1452
suggested changes
Jul 24, 2024
Co-authored-by: CJ <[email protected]>
Co-authored-by: jack <[email protected]>
Co-authored-by: jack <[email protected]>
|
Should it reset it to 0 or what it was before the last event was cancelled? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reset the exhaustion and saturation when the Food Loss handler is cancelled. This help to prevent loss very fast the food after no longer cancelling that handler.
Example
2024-07-22.17-40-15.mp4