Add regex group filter for gitlab connector, remove groups duplicates when getGroupsPermission is true #3820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add a group regex matcher to the GitLab connector config.
Remove group duplication when getGroupsPermission is true.
What this PR does / why we need it
Sometimes the IDP's can send very long list of groups, not all IDP's support group filters from the IDP side.
I've remove groups duplication when getGroupsPermission is true. I can't find any reason to keep original groups name and original groups name + permission. If someone enable getGroupsPermission flag, he expect to get only groups with permissions.
Special notes for your reviewer
I've add regex tests, but I'm not 100% that they are works well, can't run tests in local environment.
All changes I've tested manually in dev env.