simplify container dependencies in docker-compose in preparation for generating helm charts #29
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dray92
requested review from
sirstampsalot and
tylerackerson
and removed request for
sirstampsalot
tylerackerson
approved these changes
Oct 31, 2022
| @@ -20,7 +19,7 @@ services: | |||
| MYSQL_ALLOW_EMPTY_PASSWORD: "yes" | |||
| healthcheck: | |||
| test: mysql -h backend-service-db -P 3306 --user=$$MYSQL_USER --password=$$MYSQL_PASSWORD -e 'SHOW DATABASES;' | |||
| start_period: 10s | |||
| # start_period: 10s # change in docker-compose syntax support | |||
There was a problem hiding this comment.
do we need this commented-out stuff?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quite a few things changed in docker-compose from v2 to v3
now, there's some more v2 concepts being reintroduced in v3.9
this change compose spec is causing issues in using tools like
kustomizethat can help in generating k8s manifests from docker-composethe goal of this PR is to simplify the file to be able to use such tools to generate helm charts.
see https://stackoverflow.com/questions/71060072/docker-compose-depends-on-with-condition-invalid-type-should-be-an-array
Next PR:
use kustomize to generate helm charts which can deploy an equivalent app using
minikube