Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hook for url filters and few common constants #78

Merged
merged 11 commits into from
Feb 8, 2024

Conversation

eshankvaish
Copy link
Contributor

Description

  • Add a common hook for URL Filters
  • Add constants for SortingOrder and Default Page Size

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@eshankvaish eshankvaish self-assigned this Jan 25, 2024
vivek-devtron
vivek-devtron previously approved these changes Jan 28, 2024
vivek-devtron
vivek-devtron previously approved these changes Feb 5, 2024
@eshankvaish eshankvaish merged commit cd5238e into main Feb 8, 2024
3 checks passed
@eshankvaish eshankvaish deleted the feat/url-filter-hook branch February 8, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants