Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Config v2 #76

Merged
merged 9 commits into from
Feb 5, 2024
Merged

Lock Config v2 #76

merged 9 commits into from
Feb 5, 2024

Conversation

mukultayal135
Copy link
Contributor

@mukultayal135 mukultayal135 commented Jan 17, 2024

Description

  1. Non -super admin should be able to see/check what are the locked keys. Lets give view only permission of Global configuration > locked keys for admin users
  2. Placeholder suggestion disappear once user start writing, How can user see the suggestion again. Lets add the suggestions as comment in editor view
  3. In summary view of locked keys, Refer JSONpath and DT is not visible. Lets add it in preview mode as well
  4. Add checkbox for hide and show locked keys in deployment template

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

vivek-devtron
vivek-devtron previously approved these changes Jan 22, 2024
vivek-devtron
vivek-devtron previously approved these changes Jan 31, 2024
vivek-devtron
vivek-devtron previously approved these changes Jan 31, 2024
@mukultayal135 mukultayal135 merged commit 60500cf into main Feb 5, 2024
5 of 6 checks passed
@vivek-devtron vivek-devtron deleted the lock-config-v2 branch August 29, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants