Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add search bar component and generic response type #73

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

eshankvaish
Copy link
Contributor

Description

Add a search bar component with support for denounced and enter-based search.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

vivek-devtron
vivek-devtron previously approved these changes Jan 16, 2024
@eshankvaish eshankvaish changed the title feat: add search bar component feat: add search bar component and generic response type Jan 17, 2024
vivek-devtron
vivek-devtron previously approved these changes Jan 17, 2024
@eshankvaish eshankvaish merged commit b526af9 into main Jan 17, 2024
3 checks passed
@eshankvaish eshankvaish deleted the feat/search-bar branch February 9, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants