Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new confirmation modal #406

Merged
merged 18 commits into from
Nov 28, 2024
Merged

feat: add new confirmation modal #406

merged 18 commits into from
Nov 28, 2024

Conversation

arunjaindev
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

AbhishekA1509
AbhishekA1509 requested changes Nov 26, 2024
View reviewed changes
src/Shared/Helpers.tsx Show resolved Hide resolved
src/Shared/Components/Backdrop/backdrop.scss Outdated Show resolved Hide resolved
src/Shared/Components/ConfirmationModal/types.tsx Outdated Show resolved Hide resolved
src/Shared/Components/ConfirmationModal/types.tsx Outdated Show resolved Hide resolved
AbhishekA1509
AbhishekA1509 previously approved these changes Nov 27, 2024
View reviewed changes
AbhishekA1509
AbhishekA1509 previously approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@AbhishekA1509 AbhishekA1509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add description to PR template

@arunjaindev arunjaindev merged commit bd6ecae into develop Nov 28, 2024
5 checks passed
@arunjaindev arunjaindev deleted the feat/confirmation-modal branch November 28, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhishekA1509 AbhishekA1509 AbhishekA1509 approved these changes

@vivek-devtron vivek-devtron vivek-devtron approved these changes

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arunjaindev @vivek-devtron @AbhishekA1509 @Elessar1802