➡️ merge pull request #22 from devsoc-unsw/feature/login

🧪wrote more tests for the login function and added test.env variables

README.md

@@ -41,6 +41,8 @@ To run tests locally, follow the steps below.
 DATABASE_URL="postgres://postgres:postgres@localhost:5432"
 DIRECT_URL="postgres://postgres:postgres@localhost:5432"
 NODE_ENV=test
+REDIS_PORT=6380
+SESSION_SECRET=notsecret
 ```
 2. Ensure you have docker installed and make sure you have the docker engine running.
 

backend/tests/login.test.ts

@@ -45,27 +45,58 @@ describe("Tests", () => {
 
   test("Unauthorized User", async () => {
     const { status, body } = await request(app).post("/auth/register").send({
-        username: "shinjisatoo",
-        password: "testpassword",
-        email: "[email protected]",
-        userType: "ATTENDEE",
-      });
-      const users = await prisma.user.findMany({})
-      console.log(users)
-      const newUser = await prisma.user.findFirst({
-        where: {
-          id: body.newUser.id,
-        },
+      username: "shinjisatoo",
+      password: "testpassword",
+      email: "[email protected]",
+      userType: "ATTENDEE",
+    });
+
+    const newUser = await prisma.user.findFirst({
+      where: {
+        id: body.newUser.id,
+      },
+    });
+    if (newUser == null) return;
+    expect(status).toBe(201);
+    expect(newUser).not.toBeNull();
+
+    const response2 = await request(app)
+      .get("/user")
+      .send({
+        userId: newUser.id,
       });
-      if (newUser == null) return;
-      expect(status).toBe(201);
-      expect(newUser).not.toBeNull();
-
-      const response2 = await request(app)
-        .get("/user")
-        .send({
-          userId: newUser.id,
-        });
-      expect(response2.status).toBe(401);
+    expect(response2.status).toBe(401);
+  })
+
+  test("Wrong password", async () => {
+    const { status, body } = await request(app).post("/auth/register").send({
+      username: "shinjisatoo",
+      password: "testpassword",
+      email: "[email protected]",
+      userType: "ATTENDEE",
+    });
+
+    const response = await request(app).post("/auth/login").send({
+      username: body.newUser.username,
+      password: "wrongpassword",
+    });
+
+    expect(response.status).toBe(400);
+  })
+
+  test("Nonexistent Username", async () => {
+    const { status, body } = await request(app).post("/auth/register").send({
+      username: "shinjisatoo",
+      password: "testpassword",
+      email: "[email protected]",
+      userType: "ATTENDEE",
+    });
+
+    const response = await request(app).post("/auth/login").send({
+      username: "Idon'texistlol",
+      password: "testpassword",
+    });
+
+    expect(response.status).toBe(400);
   })
 });

backend/tests/register.test.ts

@@ -53,4 +53,22 @@ describe("Tests", () => {
 
     expect(status).toBe(400);
   })
+
+  test("Username already exists", async () => {
+    await request(app).post("/auth/register").send({
+      username: "shinjisatoo",
+      password: "testpassword",
+      email: "[email protected]",
+      userType: "ATTENDEE",
+    });
+
+    const { status, body } = await request(app).post("/auth/register").send({
+      username: "shinjisatoo",
+      password: "testpassword2",
+      email: "[email protected]",
+      userType: "ATTENDEE",
+    });
+
+    expect(status).toBe(400);
+  })
 });