Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ntgl 394 updated link sharing #744

Merged
merged 22 commits into from
Oct 26, 2023
Merged

Feature/ntgl 394 updated link sharing #744

merged 22 commits into from
Oct 26, 2023

Conversation

incalescence
Copy link
Contributor

@incalescence incalescence commented Jun 29, 2023 •
edited by manhualu
Loading

Updated Link Sharing

Description

  • Enhanced link sharing experience now works with copying and pasting url!
  • Easily share links to events with friends
  • Displays a preview of the event card that the user can add to their timetable
  • Will not let user add if event (with same details) already exists
  • Modal is a nested route with URL in the format notangles.csesoc.app/event/{my-custom-event-encrypted}

Demo

Notangles - Timetable Planner - Google Chrome 2023-06-29 12-35-37

@incalescence incalescence requested a review from a team as a code owner June 29, 2023 02:21
manhualu
manhualu previously requested changes Sep 1, 2023
View reviewed changes
client/src/components/timetable/ExpandedEventView.tsx Outdated Show resolved Hide resolved
client/src/components/EventShareModal.tsx Show resolved Hide resolved
client/src/components/EventShareModal.tsx Outdated Show resolved Hide resolved
@incalescence incalescence added the feature New feature or request label Sep 2, 2023
@manhualu
Copy link
Contributor

@incalescence should we support multiple timetables for the adding of the event? As right now the user can only place an event on their first default timetable

@Rayahhhmed
Copy link
Contributor

@incalescence should we support multiple timetables for the adding of the event? As right now the user can only place an event on their first default timetable

How should this be, like the user then gets to decide which timetable this event gets placed on?
Like they can select all or select couple ? that will be cool
Like a modal that pops up and they get to pick which timetable the event is at.

@Rayahhhmed Rayahhhmed merged commit 2362350 into dev Oct 26, 2023
3 checks passed
@Rayahhhmed Rayahhhmed deleted the NTGL-394-updated-link-sharing branch October 26, 2023 09:05
manhualu added a commit that referenced this pull request Nov 5, 2023
@incalescence @manhualu
Feature/ntgl 394 updated link sharing (#744)
dfb16e7 
* preview modified

* link share works xd

* refactored and tidied

* removed unused imports and styling

* error handling for invalid link

* Re-ordered imports

* changes minus refactoring

* Refactored event share modal code by using existing event styled components

* refactoring

* linting

* removed old useless code

* tidy

* Fixed white screen of death

* Location does not show on event preview card if no location given

* Reordered imports and tried to lessen repeated code for checking events are same

* Reordered imports again

* Made small edits, for type checking'

---------

Co-authored-by: manhualu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rayahhhmed Rayahhhmed Rayahhhmed approved these changes

@manhualu manhualu manhualu approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@incalescence @manhualu @Rayahhhmed