Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much stuff that I should have split up b2.2.0 final push #791

Merged
merged 25 commits into from
May 4, 2024

Conversation

MBatt1
Copy link
Contributor

@MBatt1 MBatt1 commented May 4, 2024

Additions

  • Nitra seeds can be found in Aurel towers which when grown can be used to make TNT-like blocks which are used to blast into Surtrum meteorites
    • Nitra Bunches explode immediately and detonate neighboring Bunches. Explosion is significantly smaller than normal TNT
  • Bloomed Calcite is crafted by applying a healing potion onto a calcite block.
    • Placing this block underneath soil of a plant will accelerate it's growth slightly
    • This is also the new portal frame block
  • Envoys (a skeleton variant) will now spawn at night in Paradise, and underground. They wield no weapons and have a small chance of dropping Bloomed Calcite
  • Lost Vaults can be found rarely underground with chest loot including the Glazed Gold Upgrade
    • At least 1 powerful Envoy will spawn in these structures
    • This is partially a test run of learning how to make Jigsaw structures
  • Advancements have been retuned with new features
  • Chest Boats for PL woods
  • Floestone pressure plates and buttons
  • Levita Bricks

Tweaks

  • Worldgen is scaled bigger again
  • Surtrum is made by smelting the raw Surtrum blocks. Silk Touch makes a meteorite very profitable
  • Olvite and Floestone can be used to craft many Vanilla blocks in place of Iron and Stone to grant access to some blocks and items
  • Golden Amber Tiles yield more blocks to make it easier to craft as a building material
  • Updated Tree Tap block model and item model

Removals

  • All unused plant blocks have been removed since they were unobtainable
  • Carved Stone (intended for the Slider Dungeon) has been removed
  • PL wood chests have been removed as I don't think they fit the base mod and would be better as an addon, also they will break when updating MC versions and I don't have time to maintain systems like that. Not grandfathering in old chests.
  • Removed Dollar store Aerbunny and Aechor Plant (+ it's poison dart)
  • Removed Rook

Under the hood stuff

  • Updated Incubus Core with Floating Block fixes and Noaaan/Dafaq's optimizations/paring down

Copy link

coderabbitai bot commented May 4, 2024

Walkthrough

The update involves significant changes across various components of the project, focusing on updating dependencies, refining entity behaviors, enhancing block functionalities, and streamlining rendering processes. Key updates include the introduction of new block and entity types, adjustments to item and entity attributes, and the removal of outdated features and dependencies. These modifications aim to improve performance, expand functionality, and ensure compatibility with new game versions.

Changes

File Path Change Summary
build.gradle.kts, gradle.properties Updated plugin and dependency versions.
src/main/java/net/id/paradiselost/.../blockentity/*.java Updated inheritance and methods for inventory management in various block entities.
src/main/java/net/id/paradiselost/blocks/... Added and updated various block classes, including new functionalities for ignitable blocks and crop growth mechanics.
src/main/java/net/id/paradiselost/client/... Enhanced client-side rendering and model definitions, including new entity renderers and model layers.
src/main/java/net/id/paradiselost/commands/..., src/main/java/net/id/paradiselost/component/... Removed outdated commands and components.
src/main/java/net/id/paradiselost/config/ParadiseLostConfig.java Updated block configuration for portals.
src/main/java/net/id/paradiselost/entities/... Revised entity types and behaviors, including new attributes and methods for MoaEntity and introduction of EnvoyEntity.
src/main/java/net/id/paradiselost/items/... Updated item groups and added new items. Adjustments to item properties and behaviors.
src/main/java/net/id/paradiselost/mixin/... Modifications in mixins to enhance extensibility and remove outdated functionality. Adjustments to entity and block behavior through mixins.

This table provides a structured overview of the changes applied across different files and directories, highlighting the nature and scope of updates in the project.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 15

Out of diff range and nitpick comments (8)
src/main/java/net/id/paradiselost/entities/ParadiseLostEntityExtensions.java (1)

Line range hint 3-3: Consider changing the visibility of the fields flipped, paradiseLostFallen, and gravFlipTime to private and provide public getter methods. This encapsulation will prevent unintended modifications across different instances of the implementing classes.

src/main/java/net/id/paradiselost/mixin/entity/BoatEntityTypeMixin.java (1)

29-31: The constructor of BoatEntityTypeMixin should not be used.

The constructor throws an AssertionError, which is appropriate to prevent instantiation of this mixin class. However, consider adding a comment explaining why this constructor is designed to throw an error to improve code readability.

src/main/java/net/id/paradiselost/mixin/entity/EntityMixin.java (1)

Line range hint 8-26: Consider removing or implementing the commented-out code.

The commented-out code related to velocity multipliers is not active. If it is not planned to be used, consider removing it to clean up the codebase. If it is a work in progress, add a TODO or FIXME to clarify its status.

src/main/java/net/id/paradiselost/blocks/mechanical/NitraBlock.java (1)

49-54: Logging to the console in a production environment should be avoided due to performance implications.

Consider removing or replacing System.out.println(sourcePower); with a logging framework that can be disabled or configured to a higher log level in production.

src/main/java/net/id/paradiselost/mixin/world/ExplosionMixin.java (1)

81-147: The custom explosion handling logic should ensure that it does not interfere with other mods or the base game behavior, especially with the conditional checks and the custom sound handling.

Consider testing this mixin extensively with other mods that modify explosions to ensure compatibility.

src/main/java/net/id/paradiselost/items/tools/bloodstone/BloodstoneCapturedData.java (1)

Line range hint 1-1: The class BloodstoneCapturedData should ensure that all fields are properly encapsulated and that direct access to fields (e.g., public String Race) is restricted to maintain object integrity.

Convert public fields to private and provide getter and setter methods.

src/main/java/net/id/paradiselost/ParadiseLost.java (1)

Line range hint 1-1: Ensure that all mod initialization steps are properly ordered and that dependencies between components are correctly managed to prevent initialization errors.

Review the initialization order and add dependency checks where necessary to ensure robust startup behavior.

src/main/java/net/id/paradiselost/items/ParadiseLostItems.java (1)

366-366: There is a commented-out line for adding a CHEESECAKE item. If this item is intended for future release, consider tracking it with a TODO or FIXME tag for better visibility.

coderabbitai[bot]
coderabbitai bot previously approved these changes May 4, 2024
@MBatt1 MBatt1 merged commit 627aa1d into 2.1.0/1.19.2/master May 4, 2024
0 of 4 checks passed
@MBatt1 MBatt1 deleted the 2.2.0/1.19.2/plants branch May 4, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant