-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Too much stuff that I should have split up b2.2.0 final push #791
Conversation
WalkthroughThe update involves significant changes across various components of the project, focusing on updating dependencies, refining entity behaviors, enhancing block functionalities, and streamlining rendering processes. Key updates include the introduction of new block and entity types, adjustments to item and entity attributes, and the removal of outdated features and dependencies. These modifications aim to improve performance, expand functionality, and ensure compatibility with new game versions. Changes
This table provides a structured overview of the changes applied across different files and directories, highlighting the nature and scope of updates in the project. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 15
Out of diff range and nitpick comments (8)
src/main/java/net/id/paradiselost/entities/ParadiseLostEntityExtensions.java (1)
Line range hint
3-3
: Consider changing the visibility of the fieldsflipped
,paradiseLostFallen
, andgravFlipTime
to private and provide public getter methods. This encapsulation will prevent unintended modifications across different instances of the implementing classes.src/main/java/net/id/paradiselost/mixin/entity/BoatEntityTypeMixin.java (1)
29-31
: The constructor ofBoatEntityTypeMixin
should not be used.The constructor throws an
AssertionError
, which is appropriate to prevent instantiation of this mixin class. However, consider adding a comment explaining why this constructor is designed to throw an error to improve code readability.src/main/java/net/id/paradiselost/mixin/entity/EntityMixin.java (1)
Line range hint
8-26
: Consider removing or implementing the commented-out code.The commented-out code related to velocity multipliers is not active. If it is not planned to be used, consider removing it to clean up the codebase. If it is a work in progress, add a TODO or FIXME to clarify its status.
src/main/java/net/id/paradiselost/blocks/mechanical/NitraBlock.java (1)
49-54
: Logging to the console in a production environment should be avoided due to performance implications.Consider removing or replacing
System.out.println(sourcePower);
with a logging framework that can be disabled or configured to a higher log level in production.src/main/java/net/id/paradiselost/mixin/world/ExplosionMixin.java (1)
81-147
: The custom explosion handling logic should ensure that it does not interfere with other mods or the base game behavior, especially with the conditional checks and the custom sound handling.Consider testing this mixin extensively with other mods that modify explosions to ensure compatibility.
src/main/java/net/id/paradiselost/items/tools/bloodstone/BloodstoneCapturedData.java (1)
Line range hint
1-1
: The classBloodstoneCapturedData
should ensure that all fields are properly encapsulated and that direct access to fields (e.g.,public String Race
) is restricted to maintain object integrity.Convert public fields to private and provide getter and setter methods.
src/main/java/net/id/paradiselost/ParadiseLost.java (1)
Line range hint
1-1
: Ensure that all mod initialization steps are properly ordered and that dependencies between components are correctly managed to prevent initialization errors.Review the initialization order and add dependency checks where necessary to ensure robust startup behavior.
src/main/java/net/id/paradiselost/items/ParadiseLostItems.java (1)
366-366
: There is a commented-out line for adding aCHEESECAKE
item. If this item is intended for future release, consider tracking it with a TODO or FIXME tag for better visibility.
Additions
Tweaks
Removals
Under the hood stuff