Fix Orchid deadlock 1

subgraph/Orchid#10
devrandom · Aug 23, 2014 · a012b83 · a012b83
1 parent 32a5ed3
commit a012b83
Showing 1 changed file with 14 additions and 8 deletions.
diff --git a/orchid/src/com/subgraph/orchid/circuits/CircuitIO.java b/orchid/src/com/subgraph/orchid/circuits/CircuitIO.java
@@ -37,8 +37,10 @@ public class CircuitIO implements DashboardRenderable {
 	private final BlockingQueue<Cell> controlCellResponseQueue;
 	private final Map<Integer, StreamImpl> streamMap;
 	private final Object relaySendLock = new Object();
-
+
+	/** LOCKING: streamMap */
 	private boolean isMarkedForClose;
+	/** LOCKING: streamMap */
 	private boolean isClosed;
 
 	CircuitIO(CircuitImpl circuit, Connection connection, int circuitId) {
@@ -233,19 +235,22 @@ void sendCell(Cell cell) {
 	}
 
 	void markForClose() {
+		boolean shouldClose;
 		synchronized (streamMap) {
 			if(isMarkedForClose) {
 				return;
 			}
 			isMarkedForClose = true;
-			if(streamMap.isEmpty()) {
-				closeCircuit();
-			}
+			shouldClose = streamMap.isEmpty();
 		}
+		if(shouldClose)
+			closeCircuit();
 	}
 
 	boolean isMarkedForClose() {
-		return isMarkedForClose;
+		synchronized (streamMap) {
+			return isMarkedForClose;
+		}
 	}
 
 	private void closeCircuit() {
@@ -295,12 +300,13 @@ StreamImpl createNewStream(boolean autoclose) {
 	}
 
 	void removeStream(StreamImpl stream) {
+		boolean shouldClose;
 		synchronized(streamMap) {
 			streamMap.remove(stream.getStreamId());
-			if(streamMap.isEmpty() && isMarkedForClose) {
-				closeCircuit();
-			}
+			shouldClose = streamMap.isEmpty() && isMarkedForClose;
 		}
+		if(shouldClose)
+			closeCircuit();
 	}
 
 	List<Stream> getActiveStreams() {