Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement, test GetSumDistance for systematics manager #507

Merged
merged 8 commits into from
Feb 29, 2024

Conversation

mmore500
Copy link
Member

No description provided.

@mmore500 mmore500 requested a review from emilydolson February 27, 2024 03:47
@mmore500
Copy link
Member Author

Tests are passing locally (looks like branch is overall out of sync with CI).

Copy link
Collaborator

@emilydolson emilydolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Ready for merge once tests pass

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.92%. Comparing base (279944f) to head (915bc4c).
Report is 1 commits behind head on mabe-systematics.

Additional details and impacted files
@@                Coverage Diff                @@
##           mabe-systematics     #507   +/-   ##
=================================================
  Coverage             77.92%   77.92%           
=================================================
  Files                   337      337           
  Lines                 40417    40429   +12     
=================================================
+ Hits                  31493    31504   +11     
- Misses                 8924     8925    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emilydolson emilydolson merged commit 184ae28 into mabe-systematics Feb 29, 2024
21 checks passed
@emilydolson emilydolson deleted the sum-distance-sys branch February 29, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants