Create system to help create interactive web tutorials #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FergusonAJ
changed the title
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
=======================================
Coverage 84.99% 84.99%
=======================================
Files 196 196
Lines 26846 26846
=======================================
Hits 22818 22818
Misses 4028 4028 Continue to review full report at Codecov.
|
Div.ReplaceChild functions the same as RemoveChild(old) followed by AddChild(new), only it places the new child in the old child's position in the element ordering
Document had AddX methods for most web classes (Dic, Button, Canvas, etc) but not Input. This follows the lead of those methods.
See Issue 303 Issue: 303
Listeners.h was modified to handle multiple event listeners for each event on a single element (supported by jQuery). All code changes should support backwards compatibility except for GetMap because the map itself has changed.
Listener class has new option arguments (previous commit) and this propogates those through the wrappers present in Widget and derived clases. Also adds option "in_place" arg to Widget::WrapWith. Keeps the original element's index into the the order of the parent element's children
Includes tests for EventListenerTrigger, OverlayEffect, and CSSEffect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.