Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move combine_hash function to tools/hash_utils #205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmore500
Copy link
Member

Also, write tests for combine_hash. Note that this breaks
existing levilization described in README.md... now meta
depends on tools. Update README.md to acknowledge this.

Also, write tests for combine_hash. Note that this breaks
existing levilization described in README.md... now meta
depends on tools. Update README.md to acknowledge this.
@mmore500
Copy link
Member Author

This change needs some thinking RE: levilization.

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #205 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   65.05%   65.04%   -0.02%     
==========================================
  Files          95       95              
  Lines       13153    13215      +62     
==========================================
+ Hits         8557     8596      +39     
- Misses       4596     4619      +23
Impacted Files Coverage Δ
source/tools/hash_utils.h 100% <100%> (ø) ⬆️
tests/test_tools.cc 99.37% <100%> (+0.02%) ⬆️
source/meta/meta.h 54.38% <100%> (-0.79%) ⬇️
source/hardware/AvidaGP.h 36.01% <0%> (-11.38%) ⬇️
source/hardware/InstLib.h 32.81% <0%> (-3.13%) ⬇️
tests/test_systematics.cc 96.57% <0%> (+0.28%) ⬆️
source/hardware/AvidaCPU_InstLib.h 49.01% <0%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4002225...0de7b6e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant