Add support for overriding Created and Last-Modified dates on deploy

[capyvara]

On migration/mirroring use cases, it's useful to be able to change the Created and Last Modified dates of the deployed artifacts, this PR allows to pass up an optional datetime override for both fields.

This is done by adding the X-Artifactory-Created and X-Artifactory-Last-Modified fields

[beliaev-maksim]

can you please add link to JFrog the documentation in PR description
add info to the changelog
and fix pre-commit issues

[allburov]

The function datetime_xheader doesn't work with headers, it's a serializer.
if isinstance(datetime, datetime.datetime): doesn't it lead to a bug? because datetime is not a module anymore, it's a function argument datetime_xheader(datetime)

I think if we return int, not str - it works in headers too.

Could you add a test on this?

[capyvara]

I must confess that I've not checked it, you're right the naming clash will likely mess this up, do you think it's necessary to allow the string version? I only used a datetime conversion at my code.

This is the code I've done as a hack, in which I've tried and the header works in setting up the created/last-modified date on the server:

def datetime_header(datetime):
    return str(int(round(1000*datetime.timestamp())))

# Custom version to allow change of Created and Last-Modified
def deploy_file(target, file_name, created, last_modified, parameters):
    md5 = md5sum(file_name)
    sha1 = sha1sum(file_name)
    sha256 = sha256sum(file_name)
    target = target / pathlib.Path(file_name).name

    with open(file_name, "rb") as fobj:
        url = str(target)

        matrix_parameters = (
            f";{encode_matrix_parameters(parameters)}" if parameters else None
        )
        headers = {}

        headers["X-Checksum-Md5"] = md5
        headers["X-Checksum-Sha1"] = sha1
        headers["X-Checksum-Sha256"] = sha256
        headers["X-Artifactory-Created"] = datetime_header(created)
        headers["X-Artifactory-Last-Modified"] = datetime_header(last_modified)

        target._accessor.rest_put_stream(
            url,
            fobj,
            headers=headers,
            session=target.session,
            verify=target.verify,
            cert=target.cert,
            timeout=target.timeout,
            matrix_parameters=matrix_parameters,
        )

[allburov]

Could you add a test on this?

[capyvara]

@beliaev-maksim I don't think this is documented, I stole it from their nexus migration code: https://github.com/jfrog/nexus2artifactory/blob/master/nex2art/core/Upload.py

Do you think it's a problem?

[allburov]

@capyvara @beliaev-maksim
May be we can add the hack somewhere in the FAQ section in the readme.md ?

I'm not sure that we need to have dedicated parameters for the case, people use it rarely, but we should document this especially because official Artifactory Docs doesn't have the headers.

What do you think?