Skip to content
This repository has been archived by the owner on Jul 21, 2019. It is now read-only.

List past events by month #655

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bridgetkromhout
Copy link
Contributor

@bridgetkromhout bridgetkromhout commented Sep 9, 2018

This is an MVP attempt at fixing #291. I think it's enough of an improvement that I'd like to put it in place, though improvements are welcome.

What it gets right:

  • showing the past events with months/dates makes it much easier to see what happened when (like say, if you wanted to see what month a past event was in, or what events were in a given month)

  • easier to scan than the giant columns

  • No longer duplicating future events at the end of the current year

  • Getting rid of the different way to parse the past events simplifies things.

What is still not ideal:

  • I would prefer it broken up by years, but that requires saving/comparing state in a way we're not doing right now.

  • This isn't the DRYest way to code this (but I wanted to repeat myself because I intend to change the "past" more).


This change is Reviewable

@bridgetkromhout
Copy link
Contributor Author

bridgetkromhout commented Sep 9, 2018

After noting that https://deploy-preview-655--devopsdays-theme.netlify.com/events also puts dates in reverse order inside each month, I definitely think I need a different ordering mechanism than this "reverse" one.

Learn how to organize your own devopsdays event! After each event, local organizers link to the slides and videos from their event; check individual event program pages for more info. The devopsdays vimeo account contains many videos from past events.

@bridgetkromhout
Copy link
Contributor Author

I don't like this enough to release it as-is right now.

@mattstratton
Copy link
Member

@bridgetkromhout Do you want to keep this PR open while you keep playing with it? Totally fine if that's the case.

@bridgetkromhout
Copy link
Contributor Author

Yeah, for now. Thanks.

@bridgetkromhout bridgetkromhout self-assigned this Oct 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants