Added obtaining of IAM roles. #24
Conversation
Fill up for IAM roles obtaining following previous TODO.
|
|
There was a problem hiding this comment.
@TomaszTen thank you for your contribution. I guess we will have some live discussion together. However, to also play with the process (PRs, reviews, etc.) I added some comments.
| if (reader != null) { | ||
| try { | ||
| reader.close(); | ||
| } catch (Exception exc_2) { |
There was a problem hiding this comment.
you could use try-with-resource syntax to reduce your code and make it simpler and more compact.
https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
| Process process; | ||
| try { | ||
| process = Runtime.getRuntime().exec(command); | ||
| process.waitFor(); |
There was a problem hiding this comment.
so you have changed the app to connect to AWS. Nice feature.
But should we have that by default? What if project does not want to use AWS? What if "aws" command is not available?
Do not get me wrong: I love the idea, but this could be an option or maybe we need more like a documentation having that as a code-snippet, or we could add some minimum module code for this that can be opted in.
See also:
oasp/oasp4j#633
|
Seems outdated and no further feedback. Hence, I am closing. Limiting our app template to AWS seems not to be an option. Feel free to reopen/rework... |
Fill up for IAM roles obtaining following previous TODO.