compiler: Misc improvements to code generation #2516
Conversation
FabioLuporini
requested review from
mloubout,
georgebisbas,
EdCaunt and
JDBetteridge
| @@ -540,19 +544,3 @@ def reduce_properties(clusters): | |||
| properties[d] = normalize_properties(properties.get(d, v), v) | |||
|
|
|||
| return Properties(properties) | |||
|
|
|||
|
|
|||
| def tailor_properties(properties, ispace): | |||
There was a problem hiding this comment.
note for reviewers: finally moved to ir/support/properties as promised in an old PR
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2516 +/- ##
==========================================
- Coverage 87.29% 87.27% -0.02%
==========================================
Files 238 238
Lines 45749 45875 +126
Branches 4059 4073 +14
==========================================
+ Hits 39937 40039 +102
- Misses 5127 5148 +21
- Partials 685 688 +3 ☔ View full report in Codecov by Sentry. |
|
|
||
| # Process the `weak` part of the key | ||
| for i in reversed(range(len(k.weak) + 1)): | ||
| choosable = [e for e in candidates if m[e].weak[:i] == k.weak[:i]] |
There was a problem hiding this comment.
I dont like this var name but ok
There was a problem hiding this comment.
the choosable among the candidates -- I think it's OK! why don't you like it? Im open to alternatives!
There was a problem hiding this comment.
hm, not sure....maybe like filtered, valid, eligible ?
| @@ -21,7 +21,10 @@ | |||
| from devito.tools import Bunch | |||
|
|
|||
| from examples.seismic.acoustic import acoustic_setup | |||
| from tests.test_dse import TestTTI | |||
| try: | |||
| from tests.test_dse import TestTTI | |||
There was a problem hiding this comment.
why not just from .test_dse import TestTTI. If this file is run, test_dse exists there should not be any case where this cannot be imported here
There was a problem hiding this comment.
Actually just from test_dse import TestTTI see e.g.
devito/tests/test_autotuner.py
Line 153 in da2c9a4
FabioLuporini
force-pushed
the
async-loads-final-2
branch
from
1c11eae to
72f4701
Compare
mloubout
force-pushed
the
async-loads-final-2
branch
from
72f4701 to
82fa700
Compare
In essence, this is a batch of tweaks to support GPU features in PRO