Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: Fix bug in concretization of conditionals containing Thicknesses #2510

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

EdCaunt
Copy link
Contributor

@EdCaunt EdCaunt commented Jan 6, 2025

No description provided.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.28%. Comparing base (d4ae237) to head (07f8cc5).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2510   +/-   ##
=======================================
  Coverage   87.28%   87.28%           
=======================================
  Files         238      238           
  Lines       45706    45724   +18     
  Branches     4057     4058    +1     
=======================================
+ Hits        39893    39911   +18     
  Misses       5128     5128           
  Partials      685      685           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, GTG

Copy link
Contributor

@mloubout mloubout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open an issue that subs is broken with your MFE as it might pop up again since this fix the usage not the bug

Except that GTG

Copy link
Contributor

@georgebisbas georgebisbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that CI still breaks for the scipy ascent....otherwise gtg

@FabioLuporini FabioLuporini merged commit 6615058 into master Jan 8, 2025
31 checks passed
@FabioLuporini FabioLuporini deleted the concrete branch January 8, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants