-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiler: Fix bug in concretization of conditionals containing Thicknesses #2510
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2510 +/- ##
=======================================
Coverage 87.28% 87.28%
=======================================
Files 238 238
Lines 45706 45724 +18
Branches 4057 4058 +1
=======================================
+ Hits 39893 39911 +18
Misses 5128 5128
Partials 685 685 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, GTG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you open an issue that subs is broken with your MFE as it might pop up again since this fix the usage not the bug
Except that GTG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that CI still breaks for the scipy ascent....otherwise gtg
No description provided.