misc: Revamp exception hierarchy #2500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabioLuporini
requested review from
mloubout,
georgebisbas,
EdCaunt and
JDBetteridge
FabioLuporini
force-pushed
the
improve-exceptions
branch
from
df6e14c to
a104b48
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2500 +/- ##
==========================================
- Coverage 87.28% 87.27% -0.01%
==========================================
Files 238 238
Lines 45683 45686 +3
Branches 4052 4057 +5
==========================================
- Hits 39874 39873 -1
- Misses 5123 5127 +4
Partials 686 686 ☔ View full report in Codecov by Sentry. |
mloubout
approved these changes
Dec 17, 2024
JDBetteridge
requested changes
Dec 17, 2024
|
Let me know if I'm being too picky! |
EdCaunt
reviewed
Dec 17, 2024
devito/operator/operator.py
Outdated
| @@ -188,7 +189,8 @@ def _sanitize_exprs(cls, expressions, **kwargs): | |||
|
|
|||
| for i in expressions: | |||
| if not isinstance(i, Evaluable): | |||
| raise InvalidOperator("`%s` is not an `Evaluable` object" % str(i)) | |||
| raise CompilationError(f"`{i!s}` is not an Evaluable object, " | |||
| "check again your Equation") | |||
There was a problem hiding this comment.
Nitpick: "check your equation again" would be more natural phrasing, and the comma should probably be a semicolon
| "than available (%s) " % humanbytes(available_mem) + | ||
| "on physical device, this will start swapping") | ||
| raise MemoryError( | ||
| f"Trying to allocate more memory ({humanbytes(required_mem)}) " |
FabioLuporini
force-pushed
the
improve-exceptions
branch
2 times, most recently
from
5351bff to
ab90464
Compare
FabioLuporini
force-pushed
the
improve-exceptions
branch
from
ab90464 to
140a1f5
Compare
mloubout
approved these changes
Dec 23, 2024
FabioLuporini
force-pushed
the
improve-exceptions
branch
from
140a1f5 to
29a3445
Compare
FabioLuporini
force-pushed
the
improve-exceptions
branch
from
29a3445 to
76651c8
Compare
mloubout
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was long due
Also improves handling of C-level errors