Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: Generalize lowering of reductions #1980

Merged
merged 4 commits into from
Aug 3, 2022
Merged

Conversation

FabioLuporini
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #1980 (167ee8e) into master (774720c) will decrease coverage by 0.00%.
The diff coverage is 83.87%.

❗ Current head 167ee8e differs from pull request most recent head 693485f. Consider uploading reports for the commit 693485f to get more accurate results

@@            Coverage Diff             @@
##           master    #1980      +/-   ##
==========================================
- Coverage   87.90%   87.90%   -0.01%     
==========================================
  Files         214      214              
  Lines       36232    36250      +18     
  Branches     5465     5468       +3     
==========================================
+ Hits        31849    31864      +15     
- Misses       3868     3870       +2     
- Partials      515      516       +1     
Impacted Files Coverage Δ
devito/symbolics/extended_sympy.py 96.35% <ø> (ø)
devito/passes/clusters/utils.py 96.15% <66.66%> (-3.85%) ⬇️
devito/ir/clusters/algorithms.py 94.44% <75.00%> (-1.88%) ⬇️
devito/core/cpu.py 100.00% <100.00%> (ø)
devito/core/gpu.py 76.44% <100.00%> (+0.34%) ⬆️
devito/ir/clusters/analysis.py 92.30% <100.00%> (ø)
devito/ir/clusters/cluster.py 91.74% <100.00%> (-0.35%) ⬇️
devito/passes/clusters/factorization.py 94.39% <100.00%> (+2.80%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@georgebisbas georgebisbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to try whether this can have any impact on: #1528

@mloubout mloubout force-pushed the gen-norm-reductions branch from 167ee8e to 693485f Compare August 2, 2022 22:44
@georgebisbas
Copy link
Contributor

Need to try whether this can have any impact on: #1528

no difference

@mloubout mloubout merged commit 408d35b into master Aug 3, 2022
@mloubout mloubout deleted the gen-norm-reductions branch August 3, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants